Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Adding Vaultwarden chart #83

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

✨ Adding Vaultwarden chart #83

wants to merge 6 commits into from

Conversation

lucasrattz
Copy link
Contributor

@lucasrattz lucasrattz commented Jan 23, 2024 •
edited by RJ-0605
Loading

What type of PR is this?
/kind feature
/SSO feature has been added to chart

TODOs:

  • squashed commits
  • includes documentation

lucasrattz
lucasrattz commented Jan 11, 2025
View reviewed changes
charts/vaultwarden/README.md Outdated Show resolved Hide resolved
charts/vaultwarden/values.yaml Outdated Show resolved Hide resolved
lucasrattz
lucasrattz commented Jan 11, 2025
View reviewed changes
Copy link
Contributor Author

@lucasrattz lucasrattz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, are the default values in the table on README.md really the default?

lucasrattz
lucasrattz commented Jan 13, 2025
View reviewed changes
Copy link
Contributor Author

@lucasrattz lucasrattz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the default values in the table are correct. For all values.

charts/vaultwarden/README.md Outdated Show resolved Hide resolved
charts/vaultwarden/README.md Outdated Show resolved Hide resolved
@lucasrattz
Copy link
Contributor Author

@RJ-0605 there are still parameters that have mismatching default values.

@lucasrattz
Copy link
Contributor Author

Still mismatched values...

a few examples:

  • server.image.tag
  • server.databaseURL.existingSecret.name
  • server.databaseURL.existingSecret.key
  • server.appURL -> maybe we can find a better default value here?
  • server.pvc.storageClass -> maybe we can find a better default value here? Check what other charts from reputable providers are using
  • ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RJ-0605 RJ-0605 RJ-0605 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasrattz @RJ-0605